-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-186802: Add connection string options #1324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Additionally augmented the methods that create the connection string to include these options.
slaskawi
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few questions and a suggestion but overall - great work 💪 LGTM!
Perfect! Thanks for checking!
…On Thu, Jul 6, 2023 at 12:07 PM lucian-tosa ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In api/v1/mongodbcommunity_types.go
<#1324 (comment)>
:
> @@ -119,6 +119,69 @@ type MongoDBCommunitySpec struct {
// Prometheus configurations.
// +optional
Prometheus *Prometheus `json:"prometheus,omitempty"`
+
+ // Additional options to be appended to the connection string. These options apply to the entire resource and to each user.
+ // +kubebuilder:validation:Type=object
+ // +optional
+ // +kubebuilder:pruning:PreserveUnknownFields
+ // +nullable
+ AdditionalConnectionStringConfig MapWrapper `json:"additionalConnectionStringConfig,omitempty"`
I did not try that actually. But according to this open issue:
kubernetes-sigs/controller-tools#636
<kubernetes-sigs/controller-tools#636> and the
comments that were already in the code, it should not work.
—
Reply to this email directly, view it on GitHub
<#1324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAG7BRTC6ZJ62IF24PRWTLXO2E7BANCNFSM6AAAAAAZ53YVZ4>
.
You are receiving this because your review was requested.Message ID:
***@***.***
com>
|
mircea-cosbuc
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
my-user
will have as a connection string optionreadPreference=secondary
by overriding the resource option.Closes #1134
All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if such).