CLOUDP-66230: Add E2E tests for TLS #81
Conversation
fabianlindfors
requested review from
chatton and
rodrigovalin
and removed request for
chatton
| *metav1.NewControllerRef(&mdb, schema.GroupVersionKind{ | ||
| Group: mdbv1.SchemeGroupVersion.Group, | ||
| Version: mdbv1.SchemeGroupVersion.Version, | ||
| Kind: mdb.Kind, | ||
| }))) |
There was a problem hiding this comment.
maybe we should extract this into a defaultOwnerReference function or similar. I think we have this call to metav1.NewControllerRef in several places now.
There was a problem hiding this comment.
Fixed this by refactoring all tests to use the BasicFunctionality test. Now this owner reference only appears there.
| mdb := e2eutil.NewTestMongoDB("mdb0") | ||
| mdb.Spec.Security.TLS = e2eutil.NewTestTLSConfig(false) |
There was a problem hiding this comment.
I feel like we're going to need a better way of building MongoDB resources, perhaps a builder or even for now just a separate function to fully produce a TLS enabled MDB resource. I would also suggest maybe making the resource name a bit more meaningful, even just "mdb-tls" or "mdb-tls-upgrade"
There was a problem hiding this comment.
Have updated the tests to use the name "mdb-tls" instead. As the name is embedded in the certificate I've opted to use the same for both, otherwise we would need one certificate for each test.
We discussed a builder separately and agreed it would be a nice addition. That work is tracked by a different ticket.
| return func(t *testing.T) { | ||
| ctx, cancel := context.WithCancel(context.Background()) // start a go routine which will periodically check basic MongoDB connectivity | ||
| defer cancel() |
|
@rodrigovalin I believe the test failure was caused by what I fixed in "Move context cancel outside goroutine". I'm going to run it a few times now to see if I can trigger another failure, otherwise I'll go ahead and merge. |
All Submissions:
This PR adds two E2E tests for TLS, they are:
replica_set_tls: A test for creating a new TLS-enabled cluster including a connectivity test over TLS.replica_set_tls_upgrade: A test which enables TLS on an existing cluster and ensures the cluster is reachable during the upgrade.The test certificates and keys are pre-generated and stored in
testdata/tls. This PR doesn't contain the CRD updates as it was already getting a bit big. Those changes will be a separate PR.