Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-883: Fix "Create JIRA ticket" Action #598

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jun 20, 2023

Proposed changes

Jira ticket: INTMDB-883

Follow-up PR of mongodb/terraform-provider-mongodbatlas#1255

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review June 20, 2023 07:53
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner June 20, 2023 07:53
@andreaangiolillo andreaangiolillo changed the title Update issues.yaml INTMDB-883: Fix "Create JIRA ticket" Action Jun 21, 2023
@andreaangiolillo andreaangiolillo merged commit 89e2a86 into master Jun 21, 2023
11 checks passed
@andreaangiolillo andreaangiolillo deleted the INTMDB-883_fix branch June 21, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant