Provide #delete_if for embedds many. #2339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2324.
|
Oh, these failures were there before: http://travis-ci.org/#!/mongoid/mongoid/jobs/2303507. |
|
Really that was it? I'm surprised it didn't screw up the default scoping stuff (the _unscoped target in the embeds_many). Sweet. |
|
Problem here is that the repercussions of this weren't tested and I don't have the confidence around that area to pull this in. (Ie that enumerable target would get passed on into criteria on embedded relations.) Also, the core issue was not tested and didn't actually work... The documents were removed, but nothing was actually persisted (no proper $pulls happened). |
|
Ouch, don't know why it didn't occured to me to test if its persisted - sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2324.