Backporting #2226 to 3.0 stable

[simi]

Hello. I have similar problem (https://github.com/mongoid/mongoid/issues/2226).

Any chance to get this backported to 3.0 and release new version?

Thanks, Josef

[simi]

OK, I have better solution for this. Will be pull requested in moment.

[simi]

OK, I think this is enough for backport to 3.0.

But I have different idea. We should redefine persisted? in Mongoid::State to take care of paranoid (and set self.paranoid=false for unparanoided model).

like this:

def persisted?
  paranoid ? (!new_record?) : (!new_record? && !destroyed?)
end

After we can remove this from Mongoid::Paranoia

def to_param
  new_record? ? nil : to_key.join('-')
end

Because I think it's true that object is persisted when it's deleted and some methods like to_param relies on that fact. But this change is candidate for 3.1 or 4.0 version if you're interested in. I can submit PR if you'll like it.

[durran]

I've pulled the commit from #2226 back into the 3.0.0-stable. As for the other changes I'll have a closer look for 3.1.

[simi]

I see only one commit in 3.0 stable. But another one is needed also @durran.

simi@7e22111

[simi]

And for that improvement for Paranoia. I was heavily inspired by this solution (https://github.com/radar/paranoia/blob/master/lib/paranoia.rb).

[durran]

Yeah I think that gem will be the way to go - I probably won't be doing much work work in this area being close to the 3.1 release at the moment, also given that we are removing it in 4.0.

[simi]

@durran ok, thanks. Should I decouple paranoia in separate gem? I'm really interested in it now.

[durran]

@simi That would be great! It definitely would be nice to have some love around it.

[simi]

@durran I decoupled it https://github.com/simi/mongoid-paranoia.