Rails controller runtime logging

[doooby]

Hi there, I'm bringing back an issue about logging mongoid runtime per rails controller action.

there was #3885 that failed to get into mongoid, not sure why, but now that code is incompatible.

the log message Completed 200 OK in 52ms (Views: 0.2ms | ActiveRecord: 0.4ms | MongoDB: 0.1ms) is nice but marginal feature.

we needed to collect some metrics about our rails application; this allows us to use standard rails notification:

ActiveSupport::Notifications.subscribe 'process_action.action_controller' do |*args|
  data = args.extract_options!
  data[:mongo_runtime] # accessible here
end

and please, would it be possible to put it in older versions too? (we're currently on mongoid 5.1)

[estolfo]

Hi @doooby
Thank you very much from your pull request! Would you mind adding a few lines of documentation in the code and to our tutorial?
And a few tests would be great as well.

Thanks!
Emily

[doooby]

sure, when i have the time, i'll do.

[johnnyshields]

I think this should be either "mongoid_runtime" or "mongodb_runtime"

[gnumarcelo]

Any chance this being merged soon?

[estolfo]

I'd like some documentation and tests before this is merged. Maybe @doooby has some time?

[doooby]

Sorry, I hadn't had the time for this. And for more, the reasons of the previous Travis fail goes over my understanding. But here, I've polished it a bit, added some test that made sense to me and added a mention to the doc.

also merged master from upstream.

[p-mongo]

Tracking ticket: https://jira.mongodb.org/browse/MONGOID-4631

[p-mongo]

The diff references ::Mongoid::Railties::ControllerRuntime::Instrument which does not appear to be defined anywhere, and the code that references doesn't seem to be covered by tests either.