MONGOID-3795 Add a test of callback invocation order for cascading and non-cascading callbacks #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
|
@p-mongo how can we get this fix merged? |
|
This PR is incomplete. I believe there is a decent amount of work left, and specifically the ActiveRecord callback invocation hierarchy seems to not be directly usable in Mongoid (which is what presently happens) due to Mongoid having embedded associations, for which the order of callback invocation needs to be different from the order were those associations referenced. |
p-mongo
changed the title
…d non-cascading callbacks
p-mongo
changed the title
egiurleo
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.