Fix MONGOID-4645 belongs_to in namespaced children fails to detect a non-namespaced association #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@p-mongo please, please fix your CI checks here. It's very poor form to leave these failing on every PR. |
p-mongo
changed the title
|
Thank you for the feedback, we have made a note to address the CI situation. |
p-mongo
force-pushed
the
4645
branch
4 times, most recently
from
aebb526
to
2693497
Compare
…non-namespaced association
saghm
reviewed
May 20, 2019
saghm
approved these changes
May 22, 2019
p-mongo
added a commit
that referenced
this pull request
May 23, 2019
…non-namespaced association (#4633) * Fix MONGOID-4645 belongs_to in namespaced children fails to detect a non-namespaced association * Add a docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.