Fix MONGOID-4754 Some regular expressions are missing beginning/end anchors or are using them incorrectly #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s but also extra bits
p-mongo
changed the title
saghm
approved these changes
Jun 24, 2019
p-mongo
pushed a commit
to p-mongo/mongoid
that referenced
this pull request
Jun 24, 2019
* remove-multi-value: Remove multi_value? since it is not used anywhere Fix MONGOID-4754 Some regular expressions are missing beginning/end anchors or are using them incorrectly (mongodb#4645) Fix headings in all Ruby files (mongodb#4643)
p-mongo
added a commit
that referenced
this pull request
Jun 24, 2019
…nchors or are using them incorrectly (#4645) * Fix conditions in Selector to not accept input including magic strings but also extra bits * Add tests for Numeric behavior * Cut docstring to 80 chars * multi_value? tests * Remove in? and nin? completely since they are used once and are trivial * Tests for multi_selection? * Use \A and \z for beginning/end of string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.com/browse/MONGOID-4754