Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGOID-4862 Make any_of behave like or but not disjunct the receiver #4741

Merged
merged 2 commits into from Apr 7, 2020

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Apr 7, 2020

No description provided.

@p-mongo p-mongo changed the title MONGOID-4862 4862 MONGOID-4862 Investigate making any_of behave like or but not disjunct the receiver Apr 7, 2020
@p-mongo
Copy link
Contributor Author

p-mongo commented Apr 7, 2020

@p-mongo p-mongo changed the title MONGOID-4862 Investigate making any_of behave like or but not disjunct the receiver MONGOID-4862 Make any_of behave like or but not disjunct the receiver Apr 7, 2020
end
# Should be able to do:
#where('$or' => exprs)
# But since that is broken do instead:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-mongo p-mongo requested a review from egiurleo April 7, 2020 17:10
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

When a logical operator is used, it operates on the criteria built up to
that point and its argument. ``where`` has the same meaning as ``and``:
When ``and``, ``or`` and ``nor`` logical operators are used, they
operates on the criteria built up to that point and its argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operates -> operate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@p-mongo p-mongo merged commit 72ea338 into mongodb:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants