Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MONGOID-4833 MONGOID-4849 Ruby 3.0 compatibility for 7.0 branch #4771

Merged
merged 2 commits into from May 20, 2020
Merged

MONGOID-4833 MONGOID-4849 Ruby 3.0 compatibility for 7.0 branch #4771

merged 2 commits into from May 20, 2020

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented May 20, 2020

eagleas and others added 2 commits May 20, 2020 12:05
@eagleas @p
MONGOID-4833 Avoid delegate warning message on ruby MRI 2.7.x
a800e42 
`
..lib/mongoid.rb:104: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
../.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/activesupport-5.2.4.2/lib/active_support/core_ext/module/delegation.rb:154: warning: The called method `delegate' is defined here
`
@p
MONGOID-4849 test ActiveSupport delegation (backported from mongodb#4739
c817b18 
)

Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>
@p-mongo p-mongo changed the title MONGOID-4833 MONGOID-4849 test ActiveSupport delegation (backported from #4739) MONGOID-4833 MONGOID-4849 Ruby 3.0 compatibility for 7.0 branch May 20, 2020
@p-mongo p-mongo changed the base branch from master to 7.0.0-stable May 20, 2020 16:08
@p-mongo
Copy link
Contributor Author

p-mongo commented May 20, 2020

PR for 6.4: #4760

@p-mongo p-mongo requested a review from egiurleo May 20, 2020 18:10
@p-mongo p-mongo merged commit fb9f74c into mongodb:7.0.0-stable May 20, 2020
p-mongo added a commit that referenced this pull request May 20, 2020
@p-mongo @eagleas @p
MONGOID-4833 MONGOID-4849 Ruby 3.0 compatibility for 7.0 branch (#4771)
b4ec2d5 
* MONGOID-4833 Avoid delegate warning message on ruby MRI 2.7.x

`
..lib/mongoid.rb:104: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
../.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/activesupport-5.2.4.2/lib/active_support/core_ext/module/delegation.rb:154: warning: The called method `delegate' is defined here
`

* MONGOID-4849 test ActiveSupport delegation (backported from #4739)

Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>

Co-authored-by: Alexander Oryol <eagle.alex@gmail.com>
Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@p-mongo @egiurleo @eagleas @p