MONGOID-4919 Use Mongo::Error::SessionsNotSupported for checking session support #4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
egiurleo
reviewed
Jul 13, 2020
lib/mongoid/clients/sessions.rb
Outdated
| if | ||
| # Driver 2.13.0+ | ||
| defined?(Mongo::Error::SessionsNotSupported) && | ||
| Mongo::Error::SessionsNotSupported === ex or |
There was a problem hiding this comment.
Is there a reason to use or here vs ||? All things being equal, I think I'd prefer consistent styles.
There was a problem hiding this comment.
I think I did it for emphasis but I can redo with punctuation.
egiurleo
approved these changes
Jul 13, 2020
p-mongo
added a commit
that referenced
this pull request
Jul 13, 2020
…ion support (#4812) * MONGOID-4919 Use Mongo::Error::SessionsNotSupported for checking session support * use punctuation disjunction Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>
p-mongo
added a commit
that referenced
this pull request
Jul 13, 2020
…ion support (#4812) * MONGOID-4919 Use Mongo::Error::SessionsNotSupported for checking session support * use punctuation disjunction Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.