Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGOID-5018 test cases #4914

Merged
merged 1 commit into from Nov 25, 2020
Merged

MONGOID-5018 test cases #4914

merged 1 commit into from Nov 25, 2020

Conversation

p-mongo
Copy link
Contributor

@p-mongo p-mongo commented Nov 12, 2020

@durran
Copy link
Member

durran commented Nov 23, 2020

@p-mongo My assumption was that the tests would fail when on the ticket it stated the issue was reproducible. Was this in a different environment other that the test suite that is was reproduced?

@p-mongo
Copy link
Contributor Author

p-mongo commented Nov 24, 2020

@durran If I understand your question correctly, the failing test cases are marked pending.

context 'using send' do
it 'delegates to the field' do
if reloaded
pending 'MONGOID-4018'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is pending.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh. I missed that. Thanks.

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-mongo p-mongo merged commit 39df7c8 into mongodb:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants