Fix MONGOID-5059 set nilifies attributes excluded via only
#4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
set nilifies attributes excluded via only
alexbevi
approved these changes
Apr 6, 2021
| @@ -345,9 +462,10 @@ of handling this as well. | |||
| person.attributes = { first_name: "Jean-Baptiste", middle_name: "Emmanuel" } | |||
| person.write_attributes( | |||
| first_name: "Jean-Baptiste", | |||
| middle_name: "Emmanuel" | |||
| middle_name: "Emmanuel", | |||
There was a problem hiding this comment.
I think this is a typo (the added comma) .... unless you wanted to add
last_name: "Zorg"🤣
p-mongo
added a commit
that referenced
this pull request
Apr 6, 2021
Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>
p-mongo
added a commit
that referenced
this pull request
Apr 6, 2021
Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>
p-mongo
added a commit
that referenced
this pull request
Apr 6, 2021
Co-authored-by: Oleg Pudeyev <oleg@bsdpower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.