Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MONGOID-5006 Link default auth source documentation to driver instead of incorrectly claiming "admin" is always the default #5048

Merged
merged 10 commits into from Sep 10, 2021
Merged

Fix MONGOID-5006 Link default auth source documentation to driver instead of incorrectly claiming "admin" is always the default #5048

merged 10 commits into from Sep 10, 2021

Conversation

johnnyshields
Copy link
Contributor

Fixes MONGOID-5006

Documentation only.

Also fixes some broken links.

p-mongo
p-mongo reviewed Aug 20, 2021
View reviewed changes
Copy link
Contributor

@p-mongo p-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the documents -> mongoid-documents change which I do not understand, the rest of this PR has my approval.

docs/reference/callbacks.txt Outdated Show resolved Hide resolved
docs/tutorials.txt Outdated Show resolved Hide resolved
@johnnyshields johnnyshields changed the title MONGOID-5006: Default auth source should link to driver instead of incorrectly claiming "admin" is always the default MONGOID-5006: [Documentation Only] Default auth source should link to driver instead of incorrectly claiming "admin" is always the default Aug 21, 2021
@johnnyshields
Copy link
Contributor Author

johnnyshields commented Aug 21, 2021 •
edited

@p-mongo documents -> mongoid-documents change is reverted. Please merge, thanks!

@johnnyshields
Copy link
Contributor Author

Let's merge?

p and others added 4 commits September 5, 2021 16:10
@p
Mr. Shields' suggestion
bd940f4
@johnnyshields
More terse langauge + link to server docs
abd0035
@johnnyshields
Typo
bd4ab43
@p
Merge remote-tracking branch 'upstream/master' into pr-5048
a22513a 
* upstream/master: (27 commits)
  Create security policy following github's template (mongodb#5070)
  MONGOID-5131 Use proper mdb <-> ubuntu versions (mongodb#5067)
  MONGOID-5131: Set up build pipeline for outside contributors (mongodb#5043)
  MONGOID-5165 Fix documentation link (mongodb#5065)
  Fix indentation
  MONGOID-5029 #empty method should use an #exists? rather than a #count query (mongodb#5029)
  MONGOID-5177 Fix flaky contextual spec (mongodb#5064)
  MONGOID-5170 - Fix more typos mostly in code docs and code comments (mongodb#5056)
  MONGOID-5105 Allow block form in Mongoid::Association::EmbedsMany::Proxy#count  (mongodb#5060)
  MONGOID-5162 Add a release note for the planned changes in ObjectId#as_json (mongodb#5059)
  MONGOID-5171 - Make the minimum Ruby version 2.5 (mongodb#5058)
  MONGOID-5130 Remove conn count from client spec (mongodb#5055)
  Add driver 2.15 to compat table
  Fix MONGOID-5136 .touch with custom field is broken for embedded documents (mongodb#5039)
  MONGOID-5144 Add a deprecation warning when using the legacy query cache (mongodb#5042)
  MONGOID-???? Replace field[0] == ?$ with field.start_with?('$') -- easier to read and 30%+ faster (mongodb#5052)
  MONGOID-???? - Remove BSON::ObjectId#as_json as we will defer to the bson-ruby gem implementation. (mongodb#5057)
  MONGOID-4737 Deprecate the :compact option on Document#as_json (mongodb#5040)
  MONGOID-5143 [Code Comments Only] Remove magic comment "# encoding: utf-8" (mongodb#5041)
  Remove all @SInCE comments. These are generally not useful as: (mongodb#5037)
  ...
@p-mongo p-mongo changed the title MONGOID-5006: [Documentation Only] Default auth source should link to driver instead of incorrectly claiming "admin" is always the default MONGOID-5006 [Documentation Only] Default auth source should link to driver instead of incorrectly claiming "admin" is always the default Sep 10, 2021
@p-mongo p-mongo changed the title MONGOID-5006 [Documentation Only] Default auth source should link to driver instead of incorrectly claiming "admin" is always the default Fix MONGOID-5006 Link default auth source documentation to driver instead of incorrectly claiming "admin" is always the default Sep 10, 2021
@p-mongo
Copy link
Contributor

p-mongo commented Sep 10, 2021

https://jira.mongodb.org/browse/MONGOID-5006

@p-mongo p-mongo merged commit 55b8837 into mongodb:master Sep 10, 2021
p-mongo pushed a commit to johnnyshields/mongoid that referenced this pull request Sep 22, 2021
@p
Merge branch 'master' into pr-5017
6b036c6 
* master:
  MONGOID-5151 Respect aliased fields in pluck/distinct by having Document.database_field_name recursively consider embedded docs (mongodb#5047)
  RUBY-2675 test coverage on the Mongoid side (mongodb#5030)
  MONGOID-4592 Add examples of using read_attribute and write_attribute to implement custom field behavior (mongodb#5082)
  MONGOId-5185 Remove tests for _id serialization (mongodb#5081)
  MONGOID-5103 Implement eq symbol operator (mongodb#5076)
  Fix MONGOID-5006 Link default auth source documentation to driver instead of incorrectly claiming "admin" is always the default (mongodb#5048)
  Create security policy following github's template (mongodb#5070)
p-mongo pushed a commit to johnnyshields/mongoid that referenced this pull request Sep 22, 2021
@p
Merge branch 'master' into pr-5049
c909e39 
* master:
  MONGOID-5151 Respect aliased fields in pluck/distinct by having Document.database_field_name recursively consider embedded docs (mongodb#5047)
  RUBY-2675 test coverage on the Mongoid side (mongodb#5030)
  MONGOID-4592 Add examples of using read_attribute and write_attribute to implement custom field behavior (mongodb#5082)
  MONGOId-5185 Remove tests for _id serialization (mongodb#5081)
  MONGOID-5103 Implement eq symbol operator (mongodb#5076)
  Fix MONGOID-5006 Link default auth source documentation to driver instead of incorrectly claiming "admin" is always the default (mongodb#5048)
  Create security policy following github's template (mongodb#5070)
p-mongo pushed a commit to johnnyshields/mongoid that referenced this pull request Sep 23, 2021
@p
Merge branch 'master' into pr-5025
764bca7 
* master: (26 commits)
  MONGOID-5128 Scoped associations (mongodb#5017)
  MONGOID-5005 - .sum, .count, and similar aggregables now ignore sort if not limiting/skipping (mongodb#5049)
  MONGOID-5098 Improve specs for timezone handling (specs only; no behavior change) (mongodb#5023)
  MONGOID-5151 Respect aliased fields in pluck/distinct by having Document.database_field_name recursively consider embedded docs (mongodb#5047)
  RUBY-2675 test coverage on the Mongoid side (mongodb#5030)
  MONGOID-4592 Add examples of using read_attribute and write_attribute to implement custom field behavior (mongodb#5082)
  MONGOId-5185 Remove tests for _id serialization (mongodb#5081)
  MONGOID-5103 Implement eq symbol operator (mongodb#5076)
  Fix MONGOID-5006 Link default auth source documentation to driver instead of incorrectly claiming "admin" is always the default (mongodb#5048)
  Create security policy following github's template (mongodb#5070)
  MONGOID-5131 Use proper mdb <-> ubuntu versions (mongodb#5067)
  MONGOID-5131: Set up build pipeline for outside contributors (mongodb#5043)
  MONGOID-5165 Fix documentation link (mongodb#5065)
  Fix indentation
  MONGOID-5029 #empty method should use an #exists? rather than a #count query (mongodb#5029)
  MONGOID-5177 Fix flaky contextual spec (mongodb#5064)
  MONGOID-5170 - Fix more typos mostly in code docs and code comments (mongodb#5056)
  MONGOID-5105 Allow block form in Mongoid::Association::EmbedsMany::Proxy#count  (mongodb#5060)
  MONGOID-5162 Add a release note for the planned changes in ObjectId#as_json (mongodb#5059)
  MONGOID-5171 - Make the minimum Ruby version 2.5 (mongodb#5058)
  ...
p-mongo pushed a commit to johnnyshields/mongoid that referenced this pull request Sep 23, 2021
@p
Merge branch 'master' into pr-5036
8ce4e5c 
* master:
  MONGOID-5128 Scoped associations (mongodb#5017)
  MONGOID-5005 - .sum, .count, and similar aggregables now ignore sort if not limiting/skipping (mongodb#5049)
  MONGOID-5098 Improve specs for timezone handling (specs only; no behavior change) (mongodb#5023)
  MONGOID-5151 Respect aliased fields in pluck/distinct by having Document.database_field_name recursively consider embedded docs (mongodb#5047)
  RUBY-2675 test coverage on the Mongoid side (mongodb#5030)
  MONGOID-4592 Add examples of using read_attribute and write_attribute to implement custom field behavior (mongodb#5082)
  MONGOId-5185 Remove tests for _id serialization (mongodb#5081)
  MONGOID-5103 Implement eq symbol operator (mongodb#5076)
  Fix MONGOID-5006 Link default auth source documentation to driver instead of incorrectly claiming "admin" is always the default (mongodb#5048)
  Create security policy following github's template (mongodb#5070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo comandeo comandeo approved these changes

@p-mongo p-mongo p-mongo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@johnnyshields @p-mongo @comandeo @p