MONGOID-5210 [BLOCKED] Custom field type cleanup (fix deprecation warnings) #5121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Symbol is actually supported today.) - Add ability to define custom field types.
…things for clarity in various places. This also adds documentation for previously undocumented "Custom Field Options" functionality (Mongoid::Fields.option)
…umention' into custom-field-type-support
… it makes sense to do so.
johnnyshields
changed the title
…Symbol is already supported today.) - Deprecate using field type as a Class. - Add ability to define custom field types using a mini DSL (Mongoid::Fields.configure) - Fix Mongoid::Fields.option documentation
…shields/mongoid into custom-field-type-support
…-support' into custom-field-type-cleanup
|
Per https://jira.mongodb.org/browse/MONGOID-5210?focusedCommentId=4536184&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-4536184, we do not want to demand that applications using Mongoid perform the change made by this PR (search & replace of all field types). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up from #5119 which includes its changes and also fixes all deprecation warnings. In broad strokes this means converting this:
to this: