MONGOID-5274 Add pending test for Issues with #touch method #5204
Conversation
|
|
||
| after do | ||
| Timecop.return | ||
| end |
There was a problem hiding this comment.
In my tests PR I removed Timecop, because I wanted to make sure various timestamps are actually synchronized when touching. Timecop (because it synchronizes time) will lead to false positives.
There was a problem hiding this comment.
Can you explain the case specifically where timecop will lead to false positives?
spec/mongoid/touchable_spec.rb
Outdated
| end | ||
|
|
||
| context "when touch is false on belongs_to" do | ||
| let(:parent_cls) { TouchableSpec::Referenced::Building } |
There was a problem hiding this comment.
For these types of detailed technical tests I think we should move way from "real world" class names (Building, Hospital, etc.) and have the class names be things like EmbedsOne, EmbeddedIn, etc. which describe their actual relationship.
There was a problem hiding this comment.
The problem with that is that the naming space gets too cluttered. How many "NoParent" classes are there going to be, you know? It's also not that big of a deal to just look at the class definition.
|
Is there mergeable code in this PR? If yes can you please retitle it to reflect the changes being made. |
Neilshweky
changed the title
This was previously being blocked by MONGOID-5275, but I just explicitly specified the class_name on the models so we don't have to worry about that anymore. I have added a pending test... I think this can be merged as is, and then we can decide if we want to fix this later. As the fix for this depends on our decision regarding MONGOID-5016 |
|
After we merge this we can probably just close MONGOID-5274 as a duplicate of MONGOID-5016 |
| end | ||
|
|
||
| after do | ||
| Timecop.return |
There was a problem hiding this comment.
Can this return be moved up to the topmost context added in this PR?
There was a problem hiding this comment.
The tests in this PR are separated into two contexts. I have added the return to both of them.
spec/mongoid/touchable_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| [ "save!".to_sym, :destroy, :touch].each do |meth| |
| embeds_many :entrances | ||
| embeds_many :floors | ||
| embeds_many :entrances, class_name: "TouchableSpec::Embedded::Entrance" | ||
| embeds_many :floors, class_name: "TouchableSpec::Embedded::Floor" |
There was a problem hiding this comment.
Is this needed because Mongoid does not resolve class names correctly?
* master: MONGOID-5366 add fix to 7.3.5 release notes MONGOID-5363 Document that upsert replaces existing documents (mongodb#5293) Fix MONGOID-5366 #upsert misuses #update_one (mongodb#5294) Fix MONGOID-5139 mongoid.yml template socket timeout default is incorrect (mongodb#5296) MONGOID-3601 Don't mark embedded objects as persisted when the parent is invalid (mongodb#5297) MONGOID-5077 DocumentNotFound message fails to account for shard key (mongodb#5292) MONGOID-5360 Warn when defining field types of BSON::Int64/Decimal128 and other unsupported types (mongodb#5291) MONGOID-5363 add test that #upsert replaces existing document (mongodb#5289) MONGOID-2951 Mark attributes changed when accessed via #read_attribute / subscript operator (mongodb#5284) MONGOID-4935 Fix Errors::InvalidField gives the wrong method name in description (mongodb#5287) RUBY-2947 MONGOID-5216 Update Mongoid test tooling for driver/MRSS 5.2/6.0 changes + partial work on app tests fixes (mongodb#5132) MONGOID-5345: Fix namespace_hierarchy method for anonymous classes (mongodb#5270) MONGOID-5274 Add pending test for Issues with #touch method (mongodb#5204) MONGOID-5190 Respect persistence options on auto-saved associations (mongodb#5283) MONGOID-5079 clear has_many association locally after destroy_all (mongodb#5278) MONGOID-5352 assign_attributes is working incorrectly since 7.3.4 (mongodb#5274) MONGOID-5072 Document readonly attributes ignoring assignment (mongodb#5282) MONGOID-4843 don't populate .changed_attributes setting has_and_belongs_to_many association (mongodb#5276) MONGOID-5214 add failing test case (mongodb#5128) MONGOID-5319 Permit driver FLE configuration to be specified in Mongoid config file (mongodb#5251)
No description provided.