MONGOID-5328: [WIP] Hash and localized fields assignment should work with ActionController::Parameters objects
#5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er parameters. It is necessary to call `#to_h` on the ActiveController::Parameters object, and Hash.evolve looks like the right place to do it. As a side note, to err on the side of security, I think it is better to call `#to_h` rather than `#to_unsafe_h` on the ActiveController::Parameters, which will filter out any unpermitted parameters. I need to test how this works in various scenarios (#permit!) etc.
2 tasks
johnnyshields
changed the title
ActionController::Parameters objectsActionController::Parameters objects
johnnyshields
changed the title
ActionController::Parameters objectsActionController::Parameters objects
|
@johnnyshields how do you feel about reworking this PR to take into account all of the new code that went into the mongoization epic? |
|
@Neilshweky, sure, will be glad to do it. |
|
(FYI will wait until dust settles on the mongoize/evolve refactoring before handling) |
|
Is there an update on this? |
|
@Neilshweky no update unfortunately, I've ended up not needing this for my app (I think we just called |
|
I've opened #5417 to continue this work |
|
Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
This PR makes
Object,Hashand:localizedfield assignment work withActionController::Parametersobjects, which are Hash-like but (as of Rails 5.x) do not inherit from Hash class. It is necessary to call#to_hon theActionController::Parametersobject, andHash.evolvelooks like the right place to do it.As a side note, to err on the side of security, I think it is better to call
#to_hrather than#to_unsafe_hon theActionController::Parameters, which will filter out any unpermitted parameters. I need to test how this works in various scenarios (#permit!) etc.