MONGOID-5387 Link to AR callback documentation from Mongoid callback documentation #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
| @@ -10,6 +10,10 @@ Callbacks | |||
| :depth: 2 | |||
| :class: singlecol | |||
|
|
|||
| Mongoid implements many of the `ActiveRecord callbacks | |||
| <https://guides.rubyonrails.org/active_record_callbacks.html>`_. | |||
There was a problem hiding this comment.
suggest to add ... but does not guarantee 100% feature parity.
There was a problem hiding this comment.
This simply creates confusion. Any divergences in behavior that are significant enough for users to know should be documented.
Neilshweky
approved these changes
Jun 21, 2022
p-mongo
added a commit
that referenced
this pull request
Jun 21, 2022
…documentation (#5326) Co-authored-by: Oleg Pudeyev <code@olegp.name>
p-mongo
added a commit
that referenced
this pull request
Jun 21, 2022
…documentation (#5326) Co-authored-by: Oleg Pudeyev <code@olegp.name>
p-mongo
added a commit
that referenced
this pull request
Jun 21, 2022
…documentation (#5326) Co-authored-by: Oleg Pudeyev <code@olegp.name>
p-mongo
pushed a commit
to johnnyshields/mongoid
that referenced
this pull request
Jun 27, 2022
* master: MONGOID-5381 Correct map_big_decimal_to_decimal128 feature flag default and write 8.0 release note (mongodb#5338) MONGOID-5395 Call aggregate directly on collection instead of on find view (mongodb#5343) MONGOID-5333 Document how custom fields are returned from attributes/read_attribute (mongodb#5335) MONGOID-4834 Capped collection documentation examples lack setup/context (mongodb#5337) MONGOID-5380 fix assign_attributes on embedded association to work when used before an association assignment (mongodb#5340) MONGOID-5037 use $pull instead of $pullAll for when documents change before destroying all (mongodb#5341) MONGOID-5379 Don't pass through the database_name to the collection options (mongodb#5339) MONGOID-5394 Failing test: Destroying embeds_many document when _id is nil deletes all docs (mongodb#5342) MONGOID-4160 fix feature flag reference MONGOID-5097 Test: any_of with multiple conditions and :exists in the first one on a Time field attempts to evolve true|false to Time (mongodb#5323) Mongoid operates on documents, not records (mongodb#5324) Fix MONGOID-4815 Add :conditions option example to reference documentation (mongodb#5329) MONGOID-5387 Link to AR callback documentation from Mongoid callback documentation (mongodb#5326) Tweak some callbacks documentation for grammar (mongodb#5325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.