Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONGOID-5581 Remove rspec-mocks-diag gem #5613

Merged
merged 7 commits into from
May 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .evergreen/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,14 @@ axes:
- id: "mongodb-version"
display_name: MongoDB Version
values:
- id: "latest"
display_name: "MongoDB Latest"
variables:
VERSION: "latest"
- id: "6.0"
display_name: "MongoDB 6.0"
variables:
VERSION: "5.0"
VERSION: "6.0"
- id: "5.3"
display_name: "MongoDB 5.3"
variables:
Expand Down Expand Up @@ -578,12 +582,12 @@ buildvariants:
tasks:
- name: "test"

- matrix_name: "mongodb-5.3"
- matrix_name: "mongodb-latest"
matrix_spec:
ruby: ["ruby-3.1"]
driver: ["current"]
topology: '*'
mongodb-version: ['5.3']
mongodb-version: ['latest']
os: ubuntu-20.04
display_name: "${ruby}, ${driver}, ${mongodb-version}, ${topology}"
tasks:
Expand Down Expand Up @@ -628,7 +632,7 @@ buildvariants:
driver: ["current"]
topology: ['replica-set']
mongodb-version: ['4.0']
os: ubuntu-16.04
os: ubuntu-18.04
display_name: "${ruby}, ${driver}, ${mongodb-version}, ${topology}"
tasks:
- name: "test"
Expand Down Expand Up @@ -661,7 +665,7 @@ buildvariants:
ruby: ["ruby-2.6"]
mongodb-version: "3.6"
topology: "standalone"
os: ubuntu-16.04
os: ubuntu-18.04
display_name: "${ruby}, ${driver}, ${mongodb-version}, ${topology}"
tasks:
- name: "test"
Expand Down
6 changes: 5 additions & 1 deletion .evergreen/config/axes.yml.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@ axes:
- id: "mongodb-version"
display_name: MongoDB Version
values:
- id: "latest"
display_name: "MongoDB Latest"
variables:
VERSION: "latest"
- id: "6.0"
display_name: "MongoDB 6.0"
variables:
VERSION: "5.0"
VERSION: "6.0"
- id: "5.3"
display_name: "MongoDB 5.3"
variables:
Expand Down
8 changes: 4 additions & 4 deletions .evergreen/config/variants.yml.erb
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ buildvariants:
tasks:
- name: "test"

- matrix_name: "mongodb-5.3"
- matrix_name: "mongodb-latest"
matrix_spec:
ruby: ["ruby-3.1"]
driver: ["current"]
topology: '*'
mongodb-version: ['5.3']
mongodb-version: ['latest']
os: ubuntu-20.04
display_name: "${ruby}, ${driver}, ${mongodb-version}, ${topology}"
tasks:
Expand Down Expand Up @@ -60,7 +60,7 @@ buildvariants:
driver: ["current"]
topology: ['replica-set']
mongodb-version: ['4.0']
os: ubuntu-16.04
os: ubuntu-18.04
display_name: "${ruby}, ${driver}, ${mongodb-version}, ${topology}"
tasks:
- name: "test"
Expand Down Expand Up @@ -93,7 +93,7 @@ buildvariants:
ruby: ["ruby-2.6"]
mongodb-version: "3.6"
topology: "standalone"
os: ubuntu-16.04
os: ubuntu-18.04
display_name: "${ruby}, ${driver}, ${mongodb-version}, ${topology}"
tasks:
- name: "test"
Expand Down
704 changes: 704 additions & 0 deletions .evergreen/download-mongodb.sh

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions gemfiles/standard.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ def standard_dependencies
# Evergreen configuration generation
gem 'erubi'
gem 'tilt'
gem 'solargraph'
gem 'solargraph', platform: :mri
end

group :development, :test do
gem 'rspec-core', '~> 3.10'
gem 'rspec', '~> 3.12'
gem 'rubocop', '~> 1.45.1'
gem 'rubocop-performance', '~> 1.16.0'
gem 'rubocop-rails', '~> 2.17.4'
Expand All @@ -40,8 +40,6 @@ def standard_dependencies
gem 'timecop'
gem 'rspec-retry'
gem 'benchmark-ips'
gem 'rspec-expectations', '~> 3.7', '>= 3.8.4'
gem 'rspec-mocks-diag', '~> 3.0'
gem 'fuubar'
gem 'rfc'
gem 'childprocess'
Expand Down
38 changes: 20 additions & 18 deletions spec/mongoid/config_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -570,24 +570,26 @@

it 'passes uuid to driver' do
Mongo::Client.should receive(:new).with(SpecConfig.instance.addresses,
auto_encryption_options: {
'key_vault_namespace' => 'admin.datakeys',
'kms_providers' => {'local' => {'key' => 'z7iYiYKLuYymEWtk4kfny1ESBwwFdA58qMqff96A8ghiOcIK75lJGPUIocku8LOFjQuEgeIP4xlln3s7r93FV9J5sAE7zg8U'}},
'schema_map' => {'blog_development.comments' => {
'bsonType' => 'object',
'properties' => {
'message' => {'encrypt' => {
'algorithm' => 'AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic',
'bsonType' => 'string',
'keyId' => [BSON::Binary.new("G\xF0 5\xCC@HX\xA2%b\x97\xA9a\xA8\xE7", :uuid)],
}},
},
}}},
database: 'mongoid_test',
platform: "mongoid-#{Mongoid::VERSION}",
wrapping_libraries: [
{'name' => 'Mongoid', 'version' => Mongoid::VERSION},
],
{
auto_encryption_options: {
'key_vault_namespace' => 'admin.datakeys',
'kms_providers' => {'local' => {'key' => 'z7iYiYKLuYymEWtk4kfny1ESBwwFdA58qMqff96A8ghiOcIK75lJGPUIocku8LOFjQuEgeIP4xlln3s7r93FV9J5sAE7zg8U'}},
'schema_map' => {'blog_development.comments' => {
'bsonType' => 'object',
'properties' => {
'message' => {'encrypt' => {
'algorithm' => 'AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic',
'bsonType' => 'string',
'keyId' => [BSON::Binary.new("G\xF0 5\xCC@HX\xA2%b\x97\xA9a\xA8\xE7", :uuid)],
}},
},
}}},
database: 'mongoid_test',
platform: "mongoid-#{Mongoid::VERSION}",
wrapping_libraries: [
{'name' => 'Mongoid', 'version' => Mongoid::VERSION},
]
}
)

client
Expand Down
2 changes: 1 addition & 1 deletion spec/mongoid/copyable_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
end

it 'calls constructor with explicitly declared attributes only' do
expect(Mongoid::Factory).to receive(:build).with(cls, 'name' => 'test').and_call_original
expect(Mongoid::Factory).to receive(:build).with(cls, { 'name' => 'test' }).and_call_original
cloned
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/shared
Loading