Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTOR-1139 Switch to Pytest #222

Merged
merged 37 commits into from
Aug 23, 2023
Merged

MOTOR-1139 Switch to Pytest #222

merged 37 commits into from
Aug 23, 2023

Conversation

blink1073
Copy link
Member

I created MOTOR-1174 to track switching the synchro tests to pytest.

@blink1073 blink1073 requested a review from a team as a code owner August 21, 2023 14:49
@blink1073 blink1073 requested review from NoahStapp and removed request for a team August 21, 2023 14:49
@blink1073 blink1073 marked this pull request as draft August 21, 2023 19:11
@blink1073
Copy link
Member Author

Converted to draft to fix an error on Python 3.12.

@blink1073 blink1073 marked this pull request as ready for review August 22, 2023 02:17
@NoahStapp
Copy link
Contributor

Are the existing test failures expected?

@blink1073
Copy link
Member Author

Are the existing test failures expected?

Yeah, https://jira.mongodb.org/browse/PYTHON-3852

Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great to switch over to Pytest here too!

@blink1073 blink1073 merged commit f905df8 into mongodb:master Aug 23, 2023
19 of 21 checks passed
@blink1073 blink1073 deleted the MOTOR-1139 branch August 23, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants