Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOTOR-1169 Update PyMongo Deps and Remove Workarounds #223

Merged
merged 3 commits into from
Aug 24, 2023
Merged

MOTOR-1169 Update PyMongo Deps and Remove Workarounds #223

merged 3 commits into from
Aug 24, 2023

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from a team as a code owner August 23, 2023 21:11
@blink1073 blink1073 requested review from Jibola and removed request for a team August 23, 2023 21:11
@blink1073
Copy link
Member Author

evergreen retry

1 similar comment
@blink1073
Copy link
Member Author

evergreen retry

Jibola
Jibola approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good! I did quick grep of the codebase to see if there were any missed sites, to run by you:

Here's the only one I found. If that's not relevant, let me know. Otherwise, LGTM.

@blink1073
Copy link
Member Author

Good catch! That was added in 4.4.

@blink1073 blink1073 requested a review from Jibola August 24, 2023 18:21
Jibola
Jibola approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Jibola
Jibola requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! One commentary left.

doc/changelog.rst Show resolved Hide resolved
@blink1073 blink1073 requested a review from Jibola August 24, 2023 19:40
@blink1073 blink1073 merged commit 5348e5a into mongodb:master Aug 24, 2023
33 checks passed
@blink1073 blink1073 deleted the MOTOR-1169 branch August 24, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibola Jibola Jibola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@blink1073 @Jibola