MOTOR-1187 Fix Motor Types #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Nov 10, 2023
There was a problem hiding this comment.
What about the read preference vs _ServerMode issue the user mentioned in the ticket? Can we do anything there?
AgnosticClientSession.with_transaction read_preference parameter is typed as Optional[_ServerMode] but takes Optional[pymongo.ReadPreference] type
I'm not sure why this would be specific to with_transaction though. It looks like we use _ServerMode everywhere we expect a read_preference right now.
It was already correct and we had a test for it, later in the thread the original reporter said it was a false alarm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.