Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTOR-1219 Use PyPI Trusted Publishing #240

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 requested a review from a team as a code owner November 14, 2023 12:19
@blink1073 blink1073 requested review from NoahStapp and removed request for a team November 14, 2023 12:19
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nitpicks, otherwise good.

RELEASE.rst Outdated
commit, push.

#. Publish the release version in Jira.
#. Publish the release version in Jira and add a description.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to briefly outline what the description should contain.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

RELEASE.rst Outdated

#. Upload all the release packages to PyPI with twine::
#. Bump the version number to ``<next version>.dev0`` in ``motor/_version.py``,
commit, push.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: "commit, then push."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blink1073 blink1073 merged commit d58545a into mongodb:master Nov 14, 2023
32 checks passed
@blink1073 blink1073 deleted the MOTOR-1219 branch November 14, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants