-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOTOR-1219 Use PyPI Trusted Publishing #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor nitpicks, otherwise good.
RELEASE.rst
Outdated
commit, push. | ||
|
||
#. Publish the release version in Jira. | ||
#. Publish the release version in Jira and add a description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to briefly outline what the description should contain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
RELEASE.rst
Outdated
|
||
#. Upload all the release packages to PyPI with twine:: | ||
#. Bump the version number to ``<next version>.dev0`` in ``motor/_version.py``, | ||
commit, push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: "commit, then push."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Based on https://github.com/pypa/wheel/blob/main/.github/workflows/publish.yml