Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOTOR-1279 Improve Motor Typing #269

Merged
merged 2 commits into from Mar 22, 2024
Merged

MOTOR-1279 Improve Motor Typing #269

merged 2 commits into from Mar 22, 2024

Conversation

blink1073
Copy link
Member

  • Updates typings for core.pyi to consistently return Agnostic types
  • Updates motor_asyncio.pyi and motor_tornado.pyi to subclass the Agnostic types and return framework-specific types
  • Updates test/test_typing.py to use AsyncIOMotorClient directly
  • Adds explicit typing test to ensure client.get_database() and client[database] are identical.

ShaneHarvey
ShaneHarvey approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 7bcea04 into mongodb:master Mar 22, 2024
37 checks passed
@blink1073 blink1073 deleted the MOTOR-1279 branch March 22, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@NoahStapp NoahStapp Awaiting requested review from NoahStapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@blink1073 @ShaneHarvey