Merge remote-tracking branch 'elbert3/leak-fix'

mongodb · Sep 25, 2012 · 05ad429 · 05ad429
2 parents 97ef96b + 3709204
commit 05ad429
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/mongodb/connection/repl_set.js b/lib/mongodb/connection/repl_set.js
@@ -475,13 +475,11 @@ var _connectHandler = function(self, candidateServers, instanceServer) {
       }
 
       // Make sure we have the right reference
-      if (self._state.addresses[instanceServer.host + ":" + instanceServer.port] != instanceServer) {
-        // Close the connection before deleting
-        if(self._state.addresses[instanceServer.host + ":" + instanceServer.port])
-          self._state.addresses[instanceServer.host + ":" + instanceServer.port].close();
-      }
+      var oldServer = self._state.addresses[userProvidedServerString]
+      if (oldServer && oldServer !== instanceServer) oldServer.close();
+      delete self._state.addresses[userProvidedServerString];
 
-      delete self._state.addresses[instanceServer.host + ":" + instanceServer.port];
+      if (self._state.addresses[me] && self._state.addresses[me] !== instanceServer) self._state.addresses[me].close();
       self._state.addresses[me] = instanceServer;
 
       // Let's add the server to our list of server types