fix(NODE-5592): withTransaction return type (#3846)

mongodb · Aug 28, 2023 · 05d2725 · 05d2725
1 parent 91152b9
commit 05d2725
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/sessions.ts b/src/sessions.ts
@@ -453,7 +453,7 @@ export class ClientSession extends TypedEventEmitter<ClientSessionEvents> {
   async withTransaction<T = any>(
     fn: WithTransactionCallback<T>,
     options?: TransactionOptions
-  ): Promise<Document | undefined> {
+  ): Promise<T> {
     const startTime = now();
     return attemptTransaction(this, startTime, fn, options);
   }

diff --git a/test/types/community/transaction.test-d.ts b/test/types/community/transaction.test-d.ts
@@ -1,4 +1,6 @@
-import { type ClientSession, MongoClient, ReadConcern } from '../../mongodb';
+import { expectType } from 'tsd';
+
+import { type ClientSession, type InsertOneResult, MongoClient, ReadConcern } from '../../mongodb';
 
 // TODO(NODE-3345): Improve these tests to use expect assertions more
 
@@ -111,11 +113,7 @@ try {
 client.withSession(session => runTransactionWithRetry(updateEmployeeInfo, client, session));
 
 const col = client.db('test').collection<{ _id: string }>('col');
-const ok = await session.withTransaction(async () => {
+const insertResult = await session.withTransaction(async () => {
   return await col.insertOne({ _id: 'one' }, { session });
 });
-if (ok) {
-  console.log('success');
-} else {
-  console.log('nothing done');
-}
+expectType<InsertOneResult<{ _id: string }>>(insertResult);