fix(NODE-4591): only set loadBalanced on handshake when explicitly set (

#3386)
mongodb · Aug 31, 2022 · 861d465 · 861d465
1 parent e0a36d5
commit 861d465
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 5 deletions.
diff --git a/src/cmap/connect.ts b/src/cmap/connect.ts
@@ -214,10 +214,18 @@ export interface HandshakeDocument extends Document {
   client: ClientMetadata;
   compression: string[];
   saslSupportedMechs?: string;
-  loadBalanced: boolean;
+  loadBalanced?: boolean;
 }
 
-function prepareHandshakeDocument(authContext: AuthContext, callback: Callback<HandshakeDocument>) {
+/**
+ * @internal
+ *
+ * This function is only exposed for testing purposes.
+ */
+export function prepareHandshakeDocument(
+  authContext: AuthContext,
+  callback: Callback<HandshakeDocument>
+) {
   const options = authContext.options;
   const compressors = options.compressors ? options.compressors : [];
   const { serverApi } = authContext.connection;
@@ -226,10 +234,13 @@ function prepareHandshakeDocument(authContext: AuthContext, callback: Callback<H
     [serverApi?.version ? 'hello' : LEGACY_HELLO_COMMAND]: true,
     helloOk: true,
     client: options.metadata || makeClientMetadata(options),
-    compression: compressors,
-    loadBalanced: options.loadBalanced
+    compression: compressors
   };
 
+  if (options.loadBalanced === true) {
+    handshakeDoc.loadBalanced = true;
+  }
+
   const credentials = authContext.credentials;
   if (credentials) {
     if (credentials.mechanism === AuthMechanism.MONGODB_DEFAULT && credentials.username) {

diff --git a/test/unit/cmap/connect.test.js b/test/unit/cmap/connect.test.js
@@ -5,12 +5,16 @@ const { expect } = require('chai');
 const EventEmitter = require('events');
 const { setTimeout } = require('timers');
 
-const { connect } = require('../../../src/cmap/connect');
+const {
+  connect,
+  prepareHandshakeDocument: prepareHandshakeDocumentCb
+} = require('../../../src/cmap/connect');
 const { MongoCredentials } = require('../../../src/cmap/auth/mongo_credentials');
 const { genClusterTime } = require('../../tools/common');
 const { MongoNetworkError } = require('../../../src/error');
 const { HostAddress, isHello } = require('../../../src/utils');
 const { LEGACY_HELLO_COMMAND } = require('../../../src/constants');
+const { promisify } = require('util');
 
 describe('Connect Tests', function () {
   const test = {};
@@ -112,4 +116,50 @@ describe('Connect Tests', function () {
       done();
     });
   }).skipReason = 'TODO(NODE-2941): stop using 240.0.0.1 in tests';
+
+  context('prepareHandshakeDocument', () => {
+    const prepareHandshakeDocument = promisify(prepareHandshakeDocumentCb);
+
+    context('loadBalanced option', () => {
+      context('when loadBalanced is not set as an option', () => {
+        it('does not set loadBalanced on the handshake document', async () => {
+          const options = {};
+          const authContext = {
+            connection: {},
+            options
+          };
+          const handshakeDocument = await prepareHandshakeDocument(authContext);
+          expect(handshakeDocument).not.to.have.property('loadBalanced');
+        });
+      });
+
+      context('when loadBalanced is set to false', () => {
+        it('does not set loadBalanced on the handshake document', async () => {
+          const options = {
+            loadBalanced: false
+          };
+          const authContext = {
+            connection: {},
+            options
+          };
+          const handshakeDocument = await prepareHandshakeDocument(authContext);
+          expect(handshakeDocument).not.to.have.property('loadBalanced');
+        });
+      });
+
+      context('when loadBalanced is set to true', () => {
+        it('does set loadBalanced on the handshake document', async () => {
+          const options = {
+            loadBalanced: true
+          };
+          const authContext = {
+            connection: {},
+            options
+          };
+          const handshakeDocument = await prepareHandshakeDocument(authContext);
+          expect(handshakeDocument).to.have.property('loadBalanced', true);
+        });
+      });
+    });
+  });
 });