fix: allow client connect after close #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanaPearlman
commented
Nov 6, 2020
| @@ -618,6 +617,7 @@ function processError(changeStream: ChangeStream, error: AnyError, callback?: Ca | |||
| // close internal cursor, ignore errors | |||
| cursor.close(); | |||
|
|
|||
| const topology = getTopology(changeStream.parent); | |||
| waitForTopologyConnected(topology, { readPreference: cursor.readPreference }, err => { | |||
There was a problem hiding this comment.
Accessing the topology too early in this function causes failing tests when processError is called after client close.
HanaPearlman
requested review from
mbroadst,
emadum and
nbbeeken
and removed request for
emadum
nbbeeken
approved these changes
Nov 12, 2020
HanaPearlman
force-pushed
the
NODE-2544/master/reconnect-after-close
branch
from
ceb9476
to
4e52381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reinstates the work from #2581 now that NODE-2850 is complete.
During
closeof aMongoClient, we remove thetopology. Then, when a client is reconnected, a new topology is created and added to the client. First, this means references toDbs andCollections can be re-used after the reconnect, since they will pull the new topology from the client. Also, when an operation requiring a topology is performed on a closed client, an error is thrown.After this, the work of figuring out how to re-connect a topology is one of the last steps towards having a single, immutable topology associated with a
MongoClient. As in #2581, I skipped this work for now, since the refactor required to re-connect topologies may be too much work for this ticket.NODE-2544