-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-3515): do proper opTime merging in bulk results #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
requested changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending assertions from the 3.x branch
dariakp
requested changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to update the test case names to match the assertions
nbbeeken
approved these changes
Oct 20, 2021
dariakp
requested changes
Oct 20, 2021
dariakp
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a forward port to 4.1 branch for NODE-3515.
Fixes the merging of results in a bulk write inside a transaction to properly compare and set the
opTime
value in the result.What is changing?
Per various specifications,
lastOp
andopTime
are optional fields in results that can be either aTimestamp
, or an object with ats
andt
property ofTimestamp
andLong
respectively. In some cases they are bothLongs
. Our comparison logic on these values could get into a hot mess when trying to compare values of different types. This changes theopTime
value in the bulk write result to always be an object with thets
andt
fields and never sets it as aTimestamp
value anymore.Is there new documentation needed for these changes?
No
What is the motivation for this change?
This was reported as a bug in HELP-28460 and related to NODE-3515, although the user provided patch did not solve all potential cases.
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>