fix(NODE-3727): add overloads for BulkOperationBase's execute function #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skrtheboss Thank you for submitting this suggestion. Can you please clarify what use case you are trying to support? We try to ensure that we add any missing use cases to our type test coverage so that we can avoid regressions. |
This adds overloads to the execute function, to ensure void is returned if a callback is provided, and a promise is returned if no callback is specified.
|
HI @dariakp . |
skrtheboss
changed the title
dariakp
changed the title
dariakp
added
tracked-in-jira
dariakp
requested changes
Nov 2, 2021
dariakp
added
Team Review
dariakp
approved these changes
Nov 2, 2021
dariakp
added a commit
that referenced
this pull request
Nov 2, 2021
#3018) Co-authored-by: Daria Pardue <daria.pardue@mongodb.com>
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
#3018) Co-authored-by: Daria Pardue <daria.pardue@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add overloads for BulkOperationBase's execute function.
What is changing?
This adds overloads to the execute function, to ensure void is returned if a callback is provided,
and a promise is returned if no callback is specified.
Is there new documentation needed for these changes? No.
What is the motivation for this change?
Missing overloads.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>