-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-4721): add aws-sdk as optional dependency #3446
Conversation
{ | ||
func: 'install dependencies', | ||
vars: { | ||
NPM_OPTIONS: '--no-optional' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We run the aws tests twice each now, once with the sdk installed and once without.
@@ -308,7 +308,7 @@ const AWS_AUTH_TASKS = []; | |||
|
|||
for (const VERSION of AWS_AUTH_VERSIONS) { | |||
const name = ex => `aws-${VERSION}-auth-test-${ex.split(' ').join('-')}`; | |||
const aws_funcs = [ | |||
const awsFuncs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changing name to JS conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we have really good coverage here, thanks for the CI adjustments. I think we will want to put a note about this in the Manual docs, so I did mark the ticket as docs changes needed.
The install size of the Mostly because of this new dependency being added. Can we please remove it from this package and instruct users to add this dependency in their project, if needed? EDIT: |
Description
Uses the AWS-SDK for finding credentials when present in dependencies, otherwise uses the internal implementation.
What is changing?
Patch build with AWS tests for with and without the optional dependencies:
https://spruce.mongodb.com/version/634d68f92fbabe2d0a6b964f/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Is there new documentation needed for these changes?
Can make a note to users that they can install the SDK to have it be used.
What is the motivation for this change?
NODE-4721
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>