Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-4918): import all driver APIs from one registry file #3510

Merged
merged 6 commits into from Jan 9, 2023
Merged

test(NODE-4918): import all driver APIs from one registry file #3510

merged 6 commits into from Jan 9, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 3, 2023

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review January 5, 2023 22:00
@nbbeeken nbbeeken requested a review from durran January 5, 2023 22:00
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 5, 2023
nbbeeken
nbbeeken commented Jan 6, 2023
View reviewed changes
.evergreen/install-dependencies.sh Show resolved Hide resolved
src/cmap/connection.ts Show resolved Hide resolved
src/sdam/server.ts Show resolved Hide resolved
test/integration/node-specific/bson-options/utf8_validation.test.ts Show resolved Hide resolved
test/mongodb.ts Show resolved Hide resolved
@durran durran self-assigned this Jan 9, 2023
durran
durran approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures look unrelated.

@durran durran removed their assignment Jan 9, 2023
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 9, 2023
@durran durran merged commit e6a0e14 into main Jan 9, 2023
@durran durran deleted the NODE-4918-driver-registery branch January 9, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
2 participants
@nbbeeken @durran