test(NODE-4918): import all driver APIs from one registry file (#3510)

Author: nbbeeken

.eslintrc.json

@@ -169,6 +169,7 @@
           {
             "patterns": [
               "**/../lib/**",
+              "**/../src/**",
               "mongodb-mock-server"
             ]
           }
@@ -220,6 +221,16 @@
         "@typescript-eslint/return-await": [
           "error",
           "in-try-catch"
+        ],
+        "no-restricted-imports": [
+          "error",
+          {
+            "patterns": [
+              "**/../lib/**",
+              "**/../src/**",
+              "mongodb-mock-server"
+            ]
+          }
         ]
       }
     },

.evergreen/install-dependencies.sh

@@ -4,7 +4,7 @@ set -o errexit  # Exit the script with error if any of the commands fail
 NVM_WINDOWS_URL="https://github.com/coreybutler/nvm-windows/releases/download/1.1.9/nvm-noinstall.zip"
 NVM_URL="https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh"
 
-NODE_LTS_NAME=${NODE_LTS_NAME:-erbium}
+NODE_LTS_NAME=${NODE_LTS_NAME:-fermium}
 MSVS_VERSION=${MSVS_VERSION:-2019}
 NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts"
 NPM_CACHE_DIR="${NODE_ARTIFACTS_PATH}/npm"
@@ -21,9 +21,6 @@ mkdir -p "${NPM_TMP_DIR}"
 
 function node_lts_to_version() {
   case $1 in
-    "erbium")
-      echo 12
-      ;;
     "fermium")
       echo 14
       ;;

src/cmap/connection.ts

@@ -95,22 +95,6 @@ export interface CommandOptions extends BSONSerializeOptions {
   writeConcern?: WriteConcern;
 }
 
-/** @internal */
-export interface GetMoreOptions extends CommandOptions {
-  batchSize?: number;
-  maxTimeMS?: number;
-  maxAwaitTimeMS?: number;
-  /**
-   * Comment to apply to the operation.
-   *
-   * In server versions pre-4.4, 'comment' must be string.  A server
-   * error will be thrown if any other type is provided.
-   *
-   * In server versions 4.4 and above, 'comment' can be any valid BSON type.
-   */
-  comment?: unknown;
-}
-
 /** @public */
 export interface ProxyOptions {
   proxyHost?: string;

src/index.ts

@@ -224,7 +224,6 @@ export type {
   ConnectionEvents,
   ConnectionOptions,
   DestroyOptions,
-  GetMoreOptions,
   ProxyOptions
 } from './cmap/connection';
 export type {

src/sdam/server.ts

@@ -1,5 +1,5 @@
 import type { Document } from '../bson';
-import { CommandOptions, Connection, DestroyOptions, GetMoreOptions } from '../cmap/connection';
+import { CommandOptions, Connection, DestroyOptions } from '../cmap/connection';
 import {
   ConnectionPool,
   ConnectionPoolEvents,
@@ -38,6 +38,7 @@ import {
 import { Logger } from '../logger';
 import type { ServerApi } from '../mongo_client';
 import { TypedEventEmitter } from '../mongo_types';
+import type { GetMoreOptions } from '../operations/get_more';
 import type { ClientSession } from '../sessions';
 import { isTransactionCommand } from '../transactions';
 import {
@@ -503,7 +504,7 @@ function makeOperationHandler(
       return callback(undefined, result);
     }
 
-    if (options?.noResponse === true) {
+    if (options != null && 'noResponse' in options && options.noResponse === true) {
       return callback(undefined, null);
     }
 

test/integration/auth/auth.prose.test.js

@@ -2,10 +2,10 @@
 
 const sinon = require('sinon');
 const { expect } = require('chai');
-const { Connection } = require('../../../src/cmap/connection');
-const { ScramSHA256 } = require('../../../src/cmap/auth/scram');
+const { Connection } = require('../../mongodb');
+const { ScramSHA256 } = require('../../mongodb');
 const { setupDatabase } = require('../shared');
-const { LEGACY_HELLO_COMMAND } = require('../../../src/constants');
+const { LEGACY_HELLO_COMMAND } = require('../../mongodb');
 
 // TODO(NODE-4338): withClient usage prevented these tests from running
 // the import has been removed since the function is being deleted, this is here to keep modifications minimal

test/integration/auth/scram_sha_256.test.js

@@ -2,10 +2,10 @@
 
 const sinon = require('sinon');
 const { expect } = require('chai');
-const { Connection } = require('../../../src/cmap/connection');
-const { ScramSHA256 } = require('../../../src/cmap/auth/scram');
+const { Connection } = require('../../mongodb');
+const { ScramSHA256 } = require('../../mongodb');
 const { setupDatabase } = require('../shared');
-const { LEGACY_HELLO_COMMAND } = require('../../../src/constants');
+const { LEGACY_HELLO_COMMAND } = require('../../mongodb');
 
 // TODO(NODE-4338): withClient usage prevented these tests from running
 // the import has been removed since the function is being deleted, this is here to keep modifications minimal

test/integration/causal-consistency/causal_consistency.prose.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { LEGACY_HELLO_COMMAND } = require('../../../src/constants');
+const { LEGACY_HELLO_COMMAND } = require('../../mongodb');
 
 const { setupDatabase } = require('../shared');
 const { expect } = require('chai');

test/integration/change-streams/change_stream.test.ts

@@ -22,7 +22,7 @@ import {
   ReadPreference,
   ResumeToken
 } from '../../../src';
-import { isHello } from '../../../src/utils';
+import { isHello } from '../../mongodb';
 import * as mock from '../../tools/mongodb-mock/index';
 import {
   FailPoint,

test/integration/change-streams/change_streams.prose.test.ts

@@ -13,8 +13,7 @@ import {
   ObjectId,
   Timestamp
 } from '../../../src';
-import { LEGACY_HELLO_COMMAND } from '../../../src/constants';
-import { isHello } from '../../../src/utils';
+import { isHello, LEGACY_HELLO_COMMAND } from '../../mongodb';
 import * as mock from '../../tools/mongodb-mock/index';
 import { setupDatabase } from '../shared';