Allow multiple map calls #1521
Merged
Allow multiple map calls #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, calling map multiple times on a cursor resulted in only the last map transform to be applied.
|
Do you mind adding a test case to show the usage pattern you are trying to fix. Also arrow functions cannot be used as we support node all the way back to 0.10.x in the 2.x branch. |
|
i will try :) |
copy other map test and show how multiple maps should work
|
is that ok? |
since the handling of that is in the mongodb-core library we will use a different approach, wrapping the methods
|
@mbroadst what do you think ? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, calling map multiple times on a cursor resulted in only the last map transform to be applied.