readPreference is respected on GridFSBucket.find() #1850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.find()` now used readPreference set on Bucket.
adityapatadia
changed the title
mbroadst
suggested changes
Oct 10, 2018
| @@ -213,6 +213,10 @@ GridFSBucket.prototype.find = function(filter, options) { | |||
|
|
|||
| var cursor = this.s._filesCollection.find(filter); | |||
|
|
|||
| if (this.s.options.readPreference) { | |||
There was a problem hiding this comment.
Since we support it at operation-level generally, I think a better approach might be:
const readPreference = resolveReadPreference(options, { default: this.s.options.readPreference });
if (readPreference) cursor.setReadPreference(readPreference);
Also, please document the option above!
There was a problem hiding this comment.
What is resolveReadPreference?
There was a problem hiding this comment.
it's a helper method we developed to handle type coercion and inheritance for read preferences, see here
|
@adityapatadia ping on this? We can otherwise create a JIRA ticket to track the work and close this PR |
|
I am not able to work on this and we have also stopped using GridFs.
You can handle this as you deem fit.
… On 21-Jul-2020, at 5:07 PM, Matt Broadstone ***@***.***> wrote:
@adityapatadia ping on this? We can otherwise create a JIRA ticket to track the work and close this PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Tracked by https://jira.mongodb.org/browse/NODE-2890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to specify readPreference on GridFSBucket.find(). This change makes
.find()use readPreference set on Bucket.