Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(createCollection): Db.createCollection should pass readConcern to new collection #2026

Merged
merged 13 commits into from
Jun 21, 2019
Merged

fix(createCollection): Db.createCollection should pass readConcern to new collection #2026

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7e1c6e1
perf(readConcern): Db.createCollection should pass readConcern to new…
Jun 12, 2019
ac06ce8
added empty readConcern field to test
Jun 13, 2019
9aa7524
lint
Jun 13, 2019
57de76a
add tests to verify correct readConcern inheritance
Jun 13, 2019
367b72c
create new test for createCollection and also added readConcern as il…
Jun 13, 2019
dc490b5
test createCollection and add readConcern as illegal command to fix n…
Jun 13, 2019
59629f0
modernized test
Jun 13, 2019
6e6f190
linted
Jun 14, 2019
4a73c14
using const instead of let
Jun 14, 2019
b0baadc
changed to const, closed client
Jun 14, 2019
4fc9cde
incorporated feedback, still not passing the test
Jun 18, 2019
5749843
fixed null error by putting test inside callback.
Jun 20, 2019
1d0bca9
removed comments
Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/operations/create_collection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ const illegalCommandFields = [
'raw',
'readPreference',
'session',
'readConcern'
'readConcern',
'writeConcern'
];

class CreateCollectionOperation extends CommandOperation {
Expand Down
20 changes: 10 additions & 10 deletions test/functional/readconcern_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,21 @@ describe('ReadConcern', function() {
const configuration = this.configuration;
const client = configuration.newClient(
{ w: 1 },
{ poolSize: 1, readConcern: { level: 'local' }, monitorCommands: true }
{ poolSize: 1, readConcern: { level: 'local' } }
);

client.connect(function(err, client) {
client.connect((err, client) => {
expect(err).to.not.exist;

const db = client.db(configuration.db);
test.deepEqual({ level: 'local' }, db.s.readConcern);
expect(db.s.readConcern).to.deep.equal({ level: 'local' });

// Get a collection using createCollection
const collection = db.createCollection('readConcernCollection');
// Validate readConcern
expect(test).to.deep.equal({ level: 'local' }, collection.s.readConcern);
client.close();
done();
db.createCollection('readConcernCollection', (err, collection) => {
console.log('err: ', err);
rosemaryy marked this conversation as resolved.
Show resolved Hide resolved
console.log('collection: ', collection);
// Validate readConcern
expect(collection.s.readConcern).to.deep.equal({ level: 'local' });
client.close(done);
});
});
}
});
Expand Down