NODE-1854: client side encryption test runner #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closed and re-opened to kick off a travis build |
mbroadst
force-pushed
the
NODE-1854/client-side-encryption-test-runner
branch
from
ae79bc2
to
985ac1d
Compare
daprahamian
approved these changes
Jun 16, 2019
| branches: | ||
| only: | ||
| - master | ||
| - next | ||
|
|
||
| before_install: | ||
| - wget -O mongocryptd.tgz https://s3.amazonaws.com/mciuploads/mongodb-mongo-v4.2/enterprise-ubuntu1604-64/f92115cad9d2a4c2ddcf3c2c65092dda2fd7147a/binaries/mongo-cryptd-mongodb_mongo_v4.2_enterprise_ubuntu1604_64_f92115cad9d2a4c2ddcf3c2c65092dda2fd7147a_19_06_13_17_31_40.tgz |
There was a problem hiding this comment.
nit: in the future, it might be nice to make this an npm script that we can run locally as well.
| describe('Client Side Encryption', function() { | ||
| const testContext = new TestRunnerContext(); | ||
| const testSuites = gatherTestSuites(path.join(__dirname, 'spec', 'client-side-encryption')); | ||
| after(() => testContext.teardown()); |
There was a problem hiding this comment.
q: can't recall, will the before and after scripts run if there are no tests?
| @@ -0,0 +1,25 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
The shortness of this file makes me so happy
test/functional/runner/index.js
Outdated
| 'count', | ||
|
|
||
| // we do update validation before the expectation in this test | ||
| 'an invalid update \(no \$ operators\) is validated and errors', // eslint-disable-line |
There was a problem hiding this comment.
Nit: for the future, we should make a skipList that we pass in to individual calls to generateTopologyTests instead of having a master list here.
| @@ -34,6 +42,37 @@ function generateMatchAndDiffSpecialCase(key, expectedObj, actualObj, metadata) | |||
| }; | |||
| } | |||
|
|
|||
| if (typeof expected === 'object' && Object.keys(expected)[0] === '$$type') { | |||
There was a problem hiding this comment.
nit: break this part out into a sub-function with a cool name so it is clear what this special case is.
mbroadst
force-pushed
the
NODE-1854/client-side-encryption-test-runner
branch
from
213d052
to
0066874
Compare
daprahamian
force-pushed
the
NODE-1854/client-side-encryption-test-runner
branch
from
2865ce5
to
25d5c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This completes the POC of Client Side Encryption by enabling the test runner and proving that auto encryption succeeds.
What changed?
The test suite was added, and a few small details of the driver were changed to enable the feature (adding
autoEncryptionto the list of valid option names, etc). There is an incomplete addition to the matcher included here as well for a new$$typeoperator. We should flesh this out, but for expediency only the required types have been implemented. The tests will be skipped on local systems that do not have the correct AWS credentials in their environment, but both Travis and Evergreen have been updated to provide these values.Are there any files to ignore?
No