feat: support hedged reads #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 4, 2020 17:59
Adds driver support for server Hedged Reads. Adds `hedge` property to the `ReadPreference` class and exports it using the `.toJSON` method. Introduces `withMonitoredClient` a shared testing utility for testing command monitoring. Tests command sent to the server and verifies that `hedge` property was propagated. Tests are only run on `>=3.6.0` due to how prior versions send operations to the server. NODE-2510
mbroadst
suggested changes
May 5, 2020
test/functional/shared.js
Outdated
| client.connect((err, client) => { | ||
| expect(err).to.not.exist; | ||
| const d = function() { | ||
| const args = Object.values(arguments); |
There was a problem hiding this comment.
I think this is different than what made it into 3.6
added 2 commits
May 5, 2020 10:23
added 2 commits
May 5, 2020 13:05
mbroadst
approved these changes
May 5, 2020
emadum
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds driver support for server Hedged Reads. Adds
hedgeproperty to theReadPreferenceclass and exports it using the.toJSONmethod. IntroduceswithMonitoredClienta shared testing utility for testing command monitoring. Tests command sent to the server and verifies thathedgeproperty was propagated. Tests are only run on>=3.6.0due to how prior versions send operations to the server.NODE-2510