feat: introduce AbstractCursor and its concrete subclasses #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
force-pushed
the
NODE-2809/combine-cursors
branch
2 times, most recently
from
4d30352
to
df8848e
Compare
nbbeeken
requested changes
Nov 12, 2020
mbroadst
force-pushed
the
NODE-2809/combine-cursors
branch
2 times, most recently
from
6dac300
to
631f982
Compare
nbbeeken
reviewed
Nov 13, 2020
emadum
suggested changes
Nov 16, 2020
mbroadst
force-pushed
the
NODE-2809/combine-cursors
branch
from
22dbbb6
to
6ec4082
Compare
mbroadst
force-pushed
the
NODE-2809/combine-cursors
branch
2 times, most recently
from
673e28d
to
b7a4f1a
Compare
nbbeeken
approved these changes
Nov 24, 2020
This change introduces a fundamental redesign of the cursor types in the driver. The first change is to add a new `AbstractCursor` type, which is only concerned with iterating a cursor (using `getMore`) once it has been initialized. The `_initialize` method must be implemented by subclasses. The concrete subclasses are generally builders for `find` and `aggregate` commands, each providing their own custom initialization method. NODE-2809
Co-authored-by: Eric Adum <eric.adum@mongodb.com>
mbroadst
force-pushed
the
NODE-2809/combine-cursors
branch
from
3336289
to
bcb37b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a fundamental redesign of the cursor types in the driver. The first change is to add a new
AbstractCursortype, which is only concerned with iterating a cursor (using
getMore) once it has been initialized. The_initializemethod must be implemented by subclasses. The concrete subclasses are generally builders forfindandaggregatecommands, each providing their own custom initialization method.NODE-2809