Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3074): update estimated document count for v1 api #2764

Merged
merged 8 commits into from
Apr 7, 2021
Merged

fix(NODE-3074): update estimated document count for v1 api #2764

merged 8 commits into from
Apr 7, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Mar 24, 2021 •
edited
Loading

The estimatedDocumentCount operation now uses an aggregate command
with a $collStats stage against servers >=4.9.0 (spec).

NODE-3074

@emadum emadum force-pushed the NODE-3074/update-estimated-document-count-v1 branch from b76612f to e930b52 Compare March 26, 2021 15:31
@emadum emadum marked this pull request as ready for review March 28, 2021 18:09
@emadum emadum changed the title fix: update estimated document count for v1 api fix(NODE-3074): update estimated document count for v1 api Mar 28, 2021
@emadum emadum requested review from nbbeeken and durran March 28, 2021 18:52
nbbeeken
nbbeeken requested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits:

test/unit/sessions/collection.test.js Outdated Show resolved Hide resolved
test/functional/crud_spec.test.js Outdated Show resolved Hide resolved
src/operations/estimated_document_count.ts Outdated Show resolved Hide resolved
@emadum emadum force-pushed the NODE-3074/update-estimated-document-count-v1 branch from bf0f8f0 to 9406494 Compare March 29, 2021 21:42
@emadum emadum requested a review from nbbeeken March 30, 2021 14:09
nbbeeken
nbbeeken approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

durran
durran approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit 146791c into 4.0 Apr 7, 2021
@emadum emadum deleted the NODE-3074/update-estimated-document-count-v1 branch April 7, 2021 20:58
@emadum emadum mentioned this pull request Jun 16, 2021
Merged
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
fix(NODE-3074): update estimated document count for v1 api (#2764)
5cb7a55 
The estimatedDocumentCount operation now uses an aggregate command
with a $collStats stage against 5.0+ servers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@emadum @durran @nbbeeken