feat(NODE-3333): support 'let' option for CRUD commands #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The spec tests here are fake in the sense that no upstream spec tests for this exist at this point.)
nbbeeken
reviewed
Jun 7, 2021
|
Looks like the aggregate-let tests are failing, there's an update in the spec that I think fixes it. Or you could skip it for now in: await runUnifiedTest(this, crudSpecTest, test, ['Aggregate with let option']); |
|
Err, sure, I’ll update the tests – it’s unrelated to the rest of the changes here, though – let me know if I should push them to a separate PR? |
dariakp
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Same as #2828.
Are there any files to ignore?
The spec tests here are fake in the sense that no upstream spec tests
for this exist at this point. I’ve put them next to the other tests, more or less
just assuming that somebody would notice their existence when updating
the crud spec suite to upstream and make sure they aren’t deleted.
(They are just a temporary thing here anyway.)