fix(NODE-2905): support SERVICE_NAME authentication mechanism property #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rose-m
commented
Jun 23, 2021
| 'Deprecated (or unknown) options are ignored if replacement exists', | ||
|
|
||
| // We already handle this case in different ways | ||
| 'may support deprecated gssapiServiceName option (GSSAPI)' |
There was a problem hiding this comment.
I removed this as it was the last reference to gssapiServiceName and there is no test with that description anymore.
rose-m
force-pushed
the
NODE-2905-support-service-name-auth-property
branch
from
9229b44
to
539f5eb
Compare
dariakp
added
the
Primary Review
durran
requested changes
Jun 24, 2021
test/manual/kerberos.test.js
Outdated
| ); | ||
| client.connect(function (err) { | ||
| expect(err).to.exist; | ||
| expect(err.message).to.match(/Error from KDC: LOOKING_UP_SERVER/); |
There was a problem hiding this comment.
This test is failing on Evergreen with a different error message than expected.
There was a problem hiding this comment.
Yeah... dumb me did only adapt it for the other test 🙈 should be fixed now!
rose-m
force-pushed
the
NODE-2905-support-service-name-auth-property
branch
from
539f5eb
to
a3aa420
Compare
durran
approved these changes
Jun 24, 2021
durran
requested review from
a team,
W-A-James,
dariakp and
nbbeeken
and removed request for
a team
nbbeeken
approved these changes
Jun 24, 2021
rose-m
force-pushed
the
NODE-2905-support-service-name-auth-property
branch
from
a3aa420
to
4235ec2
Compare
dariakp
requested changes
Jun 24, 2021
rose-m
force-pushed
the
NODE-2905-support-service-name-auth-property
branch
from
4235ec2
to
26c5367
Compare
durran
added
Team Review
dariakp
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
SERVICE_NAMEauthentication mechanism property that replaces the oldgssapiServiceNamequery string parameter.It also includes a test case that would set the
SERVICE_NAMEto an invalid value and verifies the connection consequently fails.NOTE: I've also started a small README file for the manual tests as I was initially unsure on how to run them locally.
Let me know if there's anything I need to adapt 😊