test(NODE-3412): sync spec tests for serverless testing #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
force-pushed
the
NODE-3412/4.0/skip-serverless-spec-tests
branch
from
b557e83
to
b68e844
Compare
emadum
force-pushed
the
NODE-3412/4.0/skip-serverless-spec-tests
branch
from
3c559ef
to
92d09f5
Compare
emadum
changed the title
emadum
changed the title
…verless-spec-tests
emadum
added
the
Primary Review
dariakp
reviewed
Jul 19, 2021
| operations.set('findOneAndDelete', async ({ entities, operation }) => { | ||
| const collection = entities.getEntity('collection', operation.object); | ||
| const { filter, ...opts } = operation.arguments; | ||
| return (await collection.findOneAndDelete(filter, opts)).value; |
There was a problem hiding this comment.
Just curious, how did this work before without extracting the value?
There was a problem hiding this comment.
I think we just didn't have any unified tests for this operation yet.
dariakp
approved these changes
Jul 19, 2021
dariakp
added
Team Review
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing various spec tests for serverless testing:
NODE-3412, NODE-3353