Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-3606): legacy and new versions of the CSFLE library #3002

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

nbbeeken
Copy link
Contributor

3.x port

  • we'll just switch fle versions based on nodejs version

@@ -22,8 +22,13 @@ fi
echo "Running kinit"
kinit -k -t "$(pwd)/.evergreen/drivers.keytab" -p ${KRB5_PRINCIPAL}

npm install kerberos
set -o xtrace
npm install kerberos@">=2.0.0-beta.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does kerberos not require a particular node version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing Node.js version condition here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbbeeken nbbeeken marked this pull request as ready for review October 14, 2021 19:19
@nbbeeken nbbeeken requested a review from dariakp October 14, 2021 20:22
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariakp dariakp merged commit 564b0d7 into 3.7 Oct 14, 2021
@dariakp dariakp deleted the NODE-3606/3.7/test-latest-fle branch October 14, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants