docs(NODE-3751): clarify contributing guidelines #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
approved these changes
Nov 5, 2021
addaleax
reviewed
Nov 5, 2021
There was a problem hiding this comment.
Should this file mention https://www.mongodb.com/contributor? Our team’s CONTRIBUTING.md files do.
@addaleax I'm happy to add it. Can you point me to a repo that has it as an example? |
ljhaywar
force-pushed
the
update-contribution-guidelines
branch
from
32e536e
to
23f7360
Compare
|
From a convo on slack: Contributor agreements are not necessary for anything Apache 2 licensed (that's how all drivers are licensed). They are only needed for contributing to things we dual license, like the server. So we can leave that out of our guide. |
durran
approved these changes
Nov 9, 2021
nbbeeken
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarified and cleaned the contributing guidelines.
What is changing?
CONTRIBUTING.md
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Clarify what confused me as I joined the project so that others don't get stuck in the same ways
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>Changes are covered by tests