test(NODE-3713): skip/fix failing evergreen tests #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-3713
branch
3 times, most recently
from
ac34bd4
to
0af06ca
Compare
durran
changed the title
durran
force-pushed
the
NODE-3713
branch
6 times, most recently
from
5ecc331
to
eb0351d
Compare
dariakp
added
the
Primary Review
dariakp
requested changes
Dec 14, 2021
| @@ -71,7 +71,7 @@ describe('Kerberos', function () { | |||
| client.connect(function (err) { | |||
| expect(err).to.exist; | |||
| expect(err.message).to.match( | |||
| /(Error from KDC: LOOKING_UP_SERVER)|(not found in Kerberos database)/ | |||
| /(Error from KDC: LOOKING_UP_SERVER)|(not found in Kerberos database)|(UNKNOWN_SERVER)/ | |||
There was a problem hiding this comment.
This is interesting - just curious how/when/why this manifested?
There was a problem hiding this comment.
It started happening last week and only on MacOS. I'm trying to pin down the root cause at the moment but Kerberos knowledge is obviously not one of my strengths.
dariakp
requested changes
Dec 16, 2021
This has been added now. |
durran
force-pushed
the
NODE-3713
branch
2 times, most recently
from
315da13
to
23f9155
Compare
This reverts commit 5fc39af.
dariakp
added
Team Review
dariakp
reviewed
Dec 17, 2021
dariakp
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skips or fixes failing non Ubuntu evergreen tests
What is changing?
Skips failing tests on MacOS and Windows plus increases test run timeouts.
Notes
The failing client side encryption corpus tests I believe will be fixed by mongodb/libmongocrypt#225
KDC error messages updated for failing Kerberos tests.
Documentation Changes
No
What is the motivation for this change?
NODE-3713
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>https://spruce.mongodb.com/version/61bc8d837742ae2cc78c16e9/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC