chore: fix invalid use of typeof operator #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Adds an eslint rule to catch my mistake. typeof x must be checked against one of the known string results.
What is the motivation for this change?
A superficial bug where we might have been defining properties and setting them to undefined when we intented to filter them out.
Since this bug has no virtually no impact, I decided against a ticket and even entering it into the changelog, happy to adjust.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>Changes are covered by testsNew TODOs have a related JIRA ticket