Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-3733): Make retryable write test error labels behave consistently with server #3140

Merged
merged 3 commits into from
Feb 9, 2022
Merged

test(NODE-3733): Make retryable write test error labels behave consistently with server #3140

merged 3 commits into from
Feb 9, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 9, 2022

Description

What is changing?

Retryable labels are supposed to be at the top level instead of nested inside the writeConcernError property.

What is the motivation for this change?

The tests have been updated to reflect what the server returns.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 9, 2022
@dariakp dariakp self-assigned this Feb 9, 2022
dariakp
dariakp requested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is missing updates to insertOne-serverErrors

@nbbeeken nbbeeken requested a review from dariakp February 9, 2022 21:00
dariakp
dariakp approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@nbbeeken nbbeeken marked this pull request as ready for review February 9, 2022 21:01
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 9, 2022
@dariakp dariakp merged commit 489e05b into main Feb 9, 2022
@dariakp dariakp deleted the NODE-3733/sync-retryable branch February 9, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@dariakp dariakp dariakp approved these changes

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@nbbeeken @baileympearson @dariakp