Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4074): ensure getTopology doens't throw #3170

Closed
wants to merge 0 commits into from

Conversation

robertsLando
Copy link

@robertsLando robertsLando commented Mar 11, 2022

Description

What is changing?

See https://www.mongodb.com/community/forums/t/nodejs-driver-v4-4-1-doesnt-handle-errors-correctly/151675

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Fixes https://www.mongodb.com/community/forums/t/nodejs-driver-v4-4-1-doesnt-handle-errors-correctly/151675

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran
Copy link
Member

durran commented Mar 11, 2022

Thanks for opening the PR. I've created a NODE ticket to track this: NODE-4074

@durran durran added the tracked-in-jira Ticket filed in MongoDB's Jira system label Mar 11, 2022
@durran durran changed the title fix: ensure getTopology doens't throw fix(NODE-4074): ensure getTopology doens't throw Mar 11, 2022
@robertsLando
Copy link
Author

robertsLando commented Mar 11, 2022

@durran Thanks. I'm even not sure about this ones:

getTopology(this),

getTopology(this),

BTW Feel free to edit my pr based on your needs

@robertsLando
Copy link
Author

@durran Anyone that could give a look at this?

@dariakp dariakp added Primary Review In Review with primary reviewer, not yet ready for team's eyes External Submission PR submitted from outside the team labels Mar 14, 2022
@baileympearson
Copy link
Contributor

Hey @robertsLando - thanks for this submission! There are a couple of changes to start I'm going to make and push to your fork

  • I'm going to rebase with main (there is a merge conflict)
  • I'm going to fix a failing test and add more tests to cover this new scenario
  • I'm going to try and get rid of the type cast as Topology in execute operation

@baileympearson
Copy link
Contributor

Hey @robertsLando I'm sorry - I messed up your fork when I attempted to push my changes. I copied your work to this PR: #3172 (and added the fixes I mentioned).

@robertsLando
Copy link
Author

@baileympearson No worries thanks for looking at this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team Primary Review In Review with primary reviewer, not yet ready for team's eyes tracked-in-jira Ticket filed in MongoDB's Jira system
Projects
None yet
4 participants